netdev - Re: [PATCH V3 net-next 0/5] add support for RFC 8335 PROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210217.142504.1617036353780732221.davem@davemloft.net>
Date:   Wed, 17 Feb 2021 14:25:04 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     andreas.a.roeseler@...il.com
Cc:     yoshfuji@...ux-ipv6.org, dsahern@...nel.org, kuba@...nel.org,
        netdev@...r.kernel.org, lkp@...el.com, dan.carpenter@...cle.com
Subject: Re: [PATCH V3 net-next 0/5] add support for RFC 8335 PROBE

From: Andreas Roeseler <andreas.a.roeseler@...il.com>
Date: Wed, 17 Feb 2021 10:07:38 -0800

> The popular utility ping has several severe limitations such as the
> inability to query specific interfaces on a node and requiring
> bidirectional connectivity between the probing and probed interfaces.
> RFC 8335 attempts to solve these limitations by creating the new utility
> PROBE which is a specialized ICMP message that makes use of the ICMP
> Extention Structure outlined in RFC 4884.
> 
> This patchset adds definitions for the ICMP Extended Echo Request and
> Reply (PROBE) types for both IPV4 and IPV6, adds a sysctl to enable 
> response to PROBE messages, expands the list of supported ICMP messages
> to accommodate PROBE types, and adds functionality to respond to PROBE
> requests.
> 
> Changes since v1:
>  - Add AFI definitions
>  - Switch to functions such as dev_get_by_name and ip_dev_find to lookup
>    net devices 
> 
> Changes since v2:
> Suggested by Willem de Brujin <willemdebrujin.kernel@...il.com>
>  - Add verification of incoming messages before looking up netdev
>  - Add prefix for PROBE specific defined variables
>  - Use proc_dointvec_minmax with zero and one  
>  - Create struct icmp_ext_echo_iio for parsing incoming packet
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
>  - Include net/addrconf.h library for ipv6_dev_find

Thi is too late for the current merge window, sorry.  Please resubmit when net-next opens
back up, thank you.