netdev - Re: [PATCH net-next] net: phy: icplus: Call phy_restore_page() when phy_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a7032cea19b8798176012f128f4977a@walle.cc>
Date:   Wed, 17 Feb 2021 11:12:11 +0100
From:   Michael Walle <michael@...le.cc>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: icplus: Call phy_restore_page() when
 phy_select_page() fails

Am 2021-02-17 11:04, schrieb Russell King - ARM Linux admin:
> On Wed, Feb 17, 2021 at 09:17:59AM +0300, Dan Carpenter wrote:
>> Smatch warns that there is a locking issue in this function:
>> 
>> drivers/net/phy/icplus.c:273 ip101a_g_config_intr_pin()
>> warn: inconsistent returns '&phydev->mdio.bus->mdio_lock'.
>>   Locked on  : 242
>>   Unlocked on: 273
>> 
>> It turns out that the comments in phy_select_page() say we have to 
>> call
>> phy_restore_page() even if the call to phy_select_page() fails.
> 
> It seems it's a total waste of time documenting functions...

You once said

"""
Kernel development is fundamentally a difficult, frustrating and
depressing activity.
"""

But really this comment doesn't make it much better. Yes I've made
a mistake although I _read_ the function documentation. So shame on
me.

-michael