netdev - Re: [PATCHv3 2/3] usbnet: add method for reporting speed without MDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210218110645.1375cfbf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 18 Feb 2021 11:06:45 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Oliver Neukum <oneukum@...e.com>
Cc:     netdev@...r.kernel.org, grundler@...omium.org, andrew@...n.ch,
        davem@...emloft.org, hayeswang@...ltek.com,
        Roland Dreier <roland@...nel.org>
Subject: Re: [PATCHv3 2/3] usbnet: add method for reporting speed without
 MDIO

On Thu, 18 Feb 2021 11:20:37 +0100 Oliver Neukum wrote:
> The old method for reporting network speed upwards
> assumed that a device uses MDIO and uses the generic phy
> functions based on that.
> Add a a primitive internal version not making the assumption
> reporting back directly what the status operations record.
> 
> v2: rebased on upstream
> v3: changed names and made clear which units are used
> 
> Signed-off-by: Oliver Neukum <oneukum@...e.com>
> Tested-by: Roland Dreier <roland@...nel.org>

ERROR: trailing whitespace
#48: FILE: drivers/net/usb/usbnet.c:1690:
+^Idev->tx_speed = SPEED_UNSET; $