netdev - Re: [PATCH net v3] net: icmp: pass zeroed opts from icmp{,v6}_ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHmME9r11eViwmghiuQsBf9k04gnWvNg8k8UPG2W4OJU3-TMnA@mail.gmail.com>
Date:   Fri, 19 Feb 2021 03:03:30 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        SinYu <liuxyon@...il.com>, Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net v3] net: icmp: pass zeroed opts from
 icmp{,v6}_ndo_send before sending

On Thu, Feb 18, 2021 at 11:06 PM Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>
> On Thu, Feb 18, 2021 at 3:39 PM Jason A. Donenfeld <Jason@...c4.com> wrote:
> >
> > The icmp{,v6}_send functions make all sorts of use of skb->cb, casting
>
> Again, if respinning, please briefly describe the specific buggy code
> path. I think it's informative and cannot be gleaned from the fix.

Ack.

> > -               send(skb, type, code, info, NULL);
> > +               send(skb, type, code, info, NULL, IP6CB(skb));
>
> This should be parm.

Nice catch, thanks.

v4 coming up.