netdev - Re: [PATCH net] dpaa_eth: fix the access method for the dpaa_napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210219144039.27be6e13@carbon>
Date:   Fri, 19 Feb 2021 14:40:39 +0100
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Camelia Groza <camelia.groza@....com>
Cc:     kuba@...nel.org, davem@...emloft.net, s.hauer@...gutronix.de,
        madalin.bucur@....nxp.com, netdev@...r.kernel.org,
        brouer@...hat.com
Subject: Re: [PATCH net] dpaa_eth: fix the access method for the
 dpaa_napi_portal

On Thu, 18 Feb 2021 20:21:06 +0200
Camelia Groza <camelia.groza@....com> wrote:

> The current use of container_of is flawed and unnecessary. Obtain
> the dpaa_napi_portal reference from the private percpu data instead.
> 
> Fixes: a1e031ffb422 ("dpaa_eth: add XDP_REDIRECT support")
> Reported-by: Sascha Hauer <s.hauer@...gutronix.de>
> Signed-off-by: Camelia Groza <camelia.groza@....com>
> ---
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer