netdev - Re: [PATCHv3 1/3] usbnet: specify naming of usbnet_set/get_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANEJEGtnPJgHT9mGY6_zQNe2Lye2N2XtzygZOyXJ2a9rE=eo9w@mail.gmail.com>
Date:   Fri, 19 Feb 2021 07:12:28 +0000
From:   Grant Grundler <grundler@...omium.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Grant Grundler <grundler@...omium.org>,
        Oliver Neukum <oneukum@...e.com>,
        netdev <netdev@...r.kernel.org>, davem@...emloft.org,
        Hayes Wang <hayeswang@...ltek.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Roland Dreier <roland@...nel.org>
Subject: Re: [PATCHv3 1/3] usbnet: specify naming of usbnet_set/get_link_ksettings

On Thu, Feb 18, 2021 at 7:50 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Thu, Feb 18, 2021 at 07:31:41PM +0000, Grant Grundler wrote:
> > Oliver, Jakub,
> > Can I post v4 and deal with the issues below?
>
> You should probably wait for two weeks. We are far enough into the
> merge window that i doubt it will get picked up. So please wait,
> rebase, and then post.

ACK - thank you.

> > Nit: The v2/v3 lines should be included BELOW the '---' line since
> > they don't belong in the commit message.
>
> netdev actually prefers them above, so we see the history of how a
> patched changed during review.

Ok. Thanks for clarifying. :)

cheers,
grant

>
>         Andrew