netdev - Re: [PATCH bpf-next v2 1/2] bpf, xdp: per-map bpf_redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7abb8101-6f4b-a79e-935b-c2377680d858@intel.com>
Date:   Sun, 21 Feb 2021 16:36:58 +0100
From:   Björn Töpel <bjorn.topel@...el.com>
To:     kernel test robot <lkp@...el.com>,
        Björn Töpel <bjorn.topel@...il.com>,
        ast@...nel.org, daniel@...earbox.net, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, maciej.fijalkowski@...el.com,
        hawk@...nel.org, toke@...hat.com, magnus.karlsson@...el.com,
        john.fastabend@...il.com
Subject: Re: [PATCH bpf-next v2 1/2] bpf, xdp: per-map bpf_redirect_map
 functions for XDP

On 2021-02-20 18:00, kernel test robot wrote:
> Hi "Björn,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on 7b1e385c9a488de9291eaaa412146d3972e9dec5]
> 
> url:    https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Optimize-bpf_redirect_map-xdp_do_redirect/20210220-233623
> base:   7b1e385c9a488de9291eaaa412146d3972e9dec5
> config: s390-randconfig-m031-20210221 (attached as .config)
> compiler: s390-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://github.com/0day-ci/linux/commit/3995bc7a37a3a7975c4a04f668408d5aa31cbe37
>          git remote add linux-review https://github.com/0day-ci/linux
>          git fetch --no-tags linux-review Bj-rn-T-pel/Optimize-bpf_redirect_map-xdp_do_redirect/20210220-233623
>          git checkout 3995bc7a37a3a7975c4a04f668408d5aa31cbe37
>          # save the attached .config to linux build tree
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
>     s390-linux-ld: kernel/bpf/verifier.o: in function `fixup_bpf_calls':
>>> verifier.c:(.text+0xa4fc): undefined reference to `get_xdp_redirect_func'
>

This is triggered when CONFIG_NET is not set. For some reason I thought
that BPF implied NET, but this was wrong. I'll fix this in v3.


Björn


> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>