netdev - Re: [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool feature command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb6b0a82-5a60-0574-6557-93aaa03fdbf1@isovalent.com>
Date:   Mon, 22 Feb 2021 16:02:48 +0000
From:   Quentin Monnet <quentin@...valent.com>
To:     grantseltzer <grantseltzer@...il.com>, andrii@...nel.org,
        daniel@...earbox.net, kafai@...com, songliubraving@...com,
        john.fastabend@...il.com, kpsingh@...nel.org
Cc:     irogers@...gle.com, yhs@...com, tklauser@...tanz.ch,
        netdev@...r.kernel.org, mrostecki@...nsuse.org, ast@...nel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool
 feature command

2021-02-20 17:13 UTC+0000 ~ grantseltzer <grantseltzer@...il.com>
> This adds the CONFIG_DEBUG_INFO_BTF kernel compile option to output of
> the bpftool feature command. This is relevant for developers that want
> to use libbpf to account for data structure definition differences
> between kernels.
> 
> Signed-off-by: grantseltzer <grantseltzer@...il.com>
> ---
>  tools/bpf/bpftool/feature.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/bpf/bpftool/feature.c b/tools/bpf/bpftool/feature.c
> index 359960a8f..b90cc6832 100644
> --- a/tools/bpf/bpftool/feature.c
> +++ b/tools/bpf/bpftool/feature.c
> @@ -336,6 +336,8 @@ static void probe_kernel_image_config(const char *define_prefix)
>  		{ "CONFIG_BPF_JIT", },
>  		/* Avoid compiling eBPF interpreter (use JIT only) */
>  		{ "CONFIG_BPF_JIT_ALWAYS_ON", },
> +		/* Kernel BTF debug information available */
> +		{ "CONFIG_DEBUG_INFO_BTF", },
>  
>  		/* cgroups */
>  		{ "CONFIG_CGROUPS", },
> 


Thanks for the change!

Reviewed-by: Quentin Monnet <quentin@...valent.com>

(Note: the date of the email is not correct, but I discussed offline
with Grant and this is now sorted out for future submissions.)

Quentin