netdev - Re: [PATCH V4 net 5/5] net: stmmac: re-init rx buffers when mac resume back

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210222114737.740469eb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 22 Feb 2021 11:47:37 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Joakim Zhang <qiangqing.zhang@....com>
Cc:     "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "alexandre.torgue@...com" <alexandre.torgue@...com>,
        "joabreu@...opsys.com" <joabreu@...opsys.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH V4 net 5/5] net: stmmac: re-init rx buffers when mac
 resume back

On Sat, 20 Feb 2021 07:52:46 +0000 Joakim Zhang wrote:
> > I'm not sure why you recycle and reallocate every buffer. Isn't it enough to
> > reinitialize the descriptors with the buffers which are already allocated?  
> 
> As I know, the receive buffer address is not fixed after allocated,
> it will recycle and re-allocate in stmmac_rx(), where to handle the
> receive buffers.

Not sure what you mean by that. The driver must know the addresses of
the memory it allocated and handed over to the device.

> It should be enough to re-initialize the descriptors with the buffers
> if it is possible. Could you point me how to do it?