netdev - Re: [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool feature command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAO658oUGKCrE8f-OvAD=1qZOOeFEYub=bLUZC1hCCQ_jVaps8g@mail.gmail.com>
Date:   Mon, 22 Feb 2021 15:05:49 -0500
From:   Grant Seltzer Richman <grantseltzer@...il.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Andrii Nakryiko <andrii@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin Lau <kafai@...com>, Song Liu <songliubraving@...com>,
        john fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, Ian Rogers <irogers@...gle.com>,
        Yonghong Song <yhs@...com>,
        Tobias Klauser <tklauser@...tanz.ch>,
        Networking <netdev@...r.kernel.org>,
        Michal Rostecki <mrostecki@...nsuse.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Quentin Monnet <quentin@...valent.com>,
        bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool
 feature command

I submitted a new patch that includes CONFIG_DEBUG_INFO_BTF_MODULES. I
renamed the patch to include this change so it's showing up as a new
thread, I also fixed the time issue, apologies for the confusion!

On Mon, Feb 22, 2021 at 2:22 PM Andrii Nakryiko
<andrii.nakryiko@...il.com> wrote:
>
> On Mon, Feb 22, 2021 at 7:34 AM grantseltzer <grantseltzer@...il.com> wrote:
> >
> > This adds the CONFIG_DEBUG_INFO_BTF kernel compile option to output of
> > the bpftool feature command. This is relevant for developers that want
> > to use libbpf to account for data structure definition differences
> > between kernels.
> >
> > Signed-off-by: grantseltzer <grantseltzer@...il.com>
>
> Signed-off-by should have a properly capitalized (where it makes
> sense) real name of the author. Is it Grant Seltzer then?
>
> > ---
> >  tools/bpf/bpftool/feature.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/tools/bpf/bpftool/feature.c b/tools/bpf/bpftool/feature.c
> > index 359960a8f..b90cc6832 100644
> > --- a/tools/bpf/bpftool/feature.c
> > +++ b/tools/bpf/bpftool/feature.c
> > @@ -336,6 +336,8 @@ static void probe_kernel_image_config(const char *define_prefix)
> >                 { "CONFIG_BPF_JIT", },
> >                 /* Avoid compiling eBPF interpreter (use JIT only) */
> >                 { "CONFIG_BPF_JIT_ALWAYS_ON", },
> > +               /* Kernel BTF debug information available */
> > +               { "CONFIG_DEBUG_INFO_BTF", },
>
> How about checking CONFIG_DEBUG_INFO_BTF_MODULES as well (i.e.,
> "Kernel module BTF information is available")?
>
> >
> >                 /* cgroups */
> >                 { "CONFIG_CGROUPS", },
> > --
> > 2.29.2
> >