netdev - Re: [PATCH net] net: dsa: b53: Support setting learning on port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9b9a186-9c9d-b2bc-82cc-c99e2012061f@gmail.com>
Date:   Mon, 22 Feb 2021 13:52:25 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: dsa: b53: Support setting learning on port



On 2/22/2021 1:46 PM, Florian Fainelli wrote:
> Add support for being able to set the learning attribute on port, and
> make sure that the standalone ports start up with learning disabled.
> 
> We can remove the code in bcm_sf2 that configured the ports learning
> attribute because we want the standalone ports to have learning disabled
> by default and port 7 cannot be bridged, so its learning attribute will
> not change past its initial configuration.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
> David, Jakub,
> 
> This is submitted against "net" because this is technically a bug fix
> since ports should not have had learning enabled by default but given
> this is dependent upon Vladimir's recent br_flags series, there is no
> Fixes tag provided.
> 
> I will be providing targeted stable backports that look a bit
> difference.

This is incorrect because I did not update the supported mask of BR_*
bits that we support, v2 coming shortly.
-- 
Florian