netdev - Re: [PATCH iproute2] dcb: Fix compilation warning about reallocarray

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b7e4dd2-1f49-ca73-ca68-91146a474e61@nvidia.com>
Date:   Mon, 22 Feb 2021 13:15:19 +0200
From:   Roi Dayan <roid@...dia.com>
To:     <netdev@...r.kernel.org>
CC:     Petr Machata <petrm@...dia.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2] dcb: Fix compilation warning about reallocarray



On 2021-02-22 12:51 PM, Roi Dayan wrote:
> To use reallocarray we need to add bsd/stdlib.h.
> 
> dcb_app.c: In function ‘dcb_app_table_push’:
> dcb_app.c:68:25: warning: implicit declaration of function ‘reallocarray’; did you mean ‘realloc’?
> 
> Fixes: 8e9bed1493f5 ("dcb: Add a subtool for the DCB APP object")
> Signed-off-by: Roi Dayan <roid@...dia.com>
> ---
>   dcb/dcb.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/dcb/dcb.c b/dcb/dcb.c
> index 6640deef5688..32896c4d5732 100644
> --- a/dcb/dcb.c
> +++ b/dcb/dcb.c
> @@ -5,6 +5,7 @@
>   #include <linux/dcbnl.h>
>   #include <libmnl/libmnl.h>
>   #include <getopt.h>
> +#include <bsd/stdlib.h>
>   
>   #include "dcb.h"
>   #include "mnl_utils.h"
> 

It seems I need this include in old centos distro but
not in fedora 27 for example as it is part of glibc.
don't merge this please.