netdev - Re: [PATCH bpf-next v2 4/4] selftests/bpf: introduce xsk statistics tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210223144136.GB51139@ranger.igk.intel.com>
Date:   Tue, 23 Feb 2021 15:41:36 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To:     Ciara Loftus <ciara.loftus@...el.com>
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org,
        magnus.karlsson@...el.com, bjorn@...nel.org,
        weqaar.a.janjua@...el.com
Subject: Re: [PATCH bpf-next v2 4/4] selftests/bpf: introduce xsk statistics
 tests

On Tue, Feb 23, 2021 at 10:35:07AM +0000, Ciara Loftus wrote:
> This commit introduces a range of tests to the xsk testsuite
> for validating xsk statistics.
> 
> A new test type called 'stats' is added. Within it there are
> four sub-tests. Each test configures a scenario which should
> trigger the given error statistic. The test passes if the statistic
> is successfully incremented.
> 
> The four statistics for which tests have been created are:
> 1. rx dropped
> Increase the UMEM frame headroom to a value which results in
> insufficient space in the rx buffer for both the packet and the headroom.
> 2. tx invalid
> Set the 'len' field of tx descriptors to an invalid value (umem frame
> size + 1).
> 3. rx ring full
> Reduce the size of the RX ring to a fraction of the fill ring size.
> 4. fill queue empty
> Do not populate the fill queue and then try to receive pkts.

Thanks for adding descriptions!

Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>

> 
> Signed-off-by: Ciara Loftus <ciara.loftus@...el.com>
> ---
>  tools/testing/selftests/bpf/xdpxceiver.c | 137 ++++++++++++++++++++---
>  tools/testing/selftests/bpf/xdpxceiver.h |  13 +++
>  2 files changed, 136 insertions(+), 14 deletions(-)
>