netdev - Re: [PATCH 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEyMn7Za9z9TUdhb8egf8mOFJyA3hgqX5fwLED8HDKw8Smyocg@mail.gmail.com>
Date:   Tue, 23 Feb 2021 16:04:16 +0100
From:   Heiko Thiery <heiko.thiery@...il.com>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Fugang Duan <fugang.duan@....com>
Subject: Re: [PATCH 1/1] net: fec: ptp: avoid register access when ipg clock
 is disabled

Hi Richard,

Am Di., 23. Feb. 2021 um 15:27 Uhr schrieb Richard Cochran
<richardcochran@...il.com>:
>
> On Tue, Feb 23, 2021 at 09:00:32AM +0100, Heiko Thiery wrote:
> > HI Jakub,
> >
> > Am Di., 23. Feb. 2021 um 04:00 Uhr schrieb Jakub Kicinski <kuba@...nel.org>:
> > > Why is the PTP interface registered when it can't be accessed?
> > >
> > > Perhaps the driver should unregister the PTP clock when it's brought
> > > down?
>
> I don't see any reason why a clock should stop ticking just because
> the interface is down.  This is a poor driver design, but sadly it
> gets copied and even defended.

It is not only the PHC clock that stops. Rather, it is the entire
ethernet building block in the SOC that is disabled, including the
PHC.

> > Good question, but I do not know what happens e.g. with linuxptp when
> > the device that was opened before will be gone.
>
> If a network interface goes down, ptp4l will notice via rtnl and close
> the interface.  Then it re-opens the sockets on rtnl up.  However, the
> file descriptor representing the dynamic posix clock stays opened.

Thanks,

-- 
Heiko