netdev - Re: [PATCH ipsec,v2] xfrm: interface: fix ipv4 pmtu check to honor ip header df

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHsH6Gs2=siz4a4CZAe3NDnKuhZKQDRk-kbB2ZdGjM1w9c2njQ@mail.gmail.com>
Date:   Tue, 23 Feb 2021 17:37:14 +0200
From:   Eyal Birger <eyal.birger@...il.com>
To:     Sabrina Dubroca <sd@...asysnail.net>
Cc:     Steffen Klassert <steffen.klassert@...unet.com>,
        herbert@...dor.apana.org.au, David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH ipsec,v2] xfrm: interface: fix ipv4 pmtu check to honor ip
 header df

Hi,

On Tue, Feb 23, 2021 at 5:18 PM Sabrina Dubroca <sd@...asysnail.net> wrote:
>
> 2021-02-20, 15:01:15 +0200, Eyal Birger wrote:
> > Frag needed should only be sent if the header enables DF.
> >
> > This fix allows packets larger than MTU to pass the xfrm interface
> > and be fragmented after encapsulation, aligning behavior with
> > non-interface xfrm.
> >
> > Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces")
> > Signed-off-by: Eyal Birger <eyal.birger@...il.com>
> >
> > -----
> >
> > v2: better align coding with ip_vti
>
> LGTM. We also need to do the same thing in ip_vti and ip6_vti. Do you
> want to take care of it, or should I?

I can submit the same fix for vti{,6}.

>
> Either way, for this patch:
> Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

Thanks!
Eyal.