netdev - RE: net: phy: ti: implement generic .handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB8P190MB0634C73B4363753F62FCE4B6D9809@DB8P190MB0634.EURP190.PROD.OUTLOOK.COM>
Date:   Tue, 23 Feb 2021 17:44:57 +0000
From:   Sven Schuchmann <schuchmann@...leissheimer.de>
To:     Dan Murphy <dmurphy@...com>,
        "ioana.ciornei@....com" <ioana.ciornei@....com>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: RE: net: phy: ti: implement generic .handle_interrupt() callback

Hello all,

I am working with the DP83TC811R but for now on the 5.10 kernel.
I have seen this patch on the latest dev
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/phy/dp83tc811.c?h=v5.11&id=1d1ae3c6ca3ff49843d73852bb2a8153ce16f432

I did not test it yet, but I wonder about one thing:
What happens when there are 2 Flags set e.g.
in INT_STAT1 and one in INT_STAT2?
What I see from the code is that it would
only read (and acknowledge) the first one and
then quit out to trigger_machine.

Any thoughts about this?

Best Regards,

   Sven