netdev - Re: [PATCH v2 net] net: phy: micrel: set soft_reset callback to genphy_soft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210223112402.7ed1fe93@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 23 Feb 2021 11:24:02 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Christian Melki <christian.melki@...ata.com>
Cc:     netdev@...r.kernel.org, andrew@...n.ch, hkallweit1@...il.com,
        f.fainelli@...il.com
Subject: Re: [PATCH v2 net] net: phy: micrel: set soft_reset callback to
 genphy_soft_reset for KSZ8081

On Tue, 23 Feb 2021 09:30:30 +0100 Christian Melki wrote:
> Following a similar reinstate for the KSZ9031.
> 
> Older kernels would use the genphy_soft_reset if the PHY did not 
> implement a .soft_reset.
> 
> Bluntly removing that default may expose a lot of situations where 
> various PHYs/board implementations won't recover on various changes.
> Like with tgus implementation during a 4.9.x to 5.4.x LTS transition.
> I think it's a good thing to remove unwanted soft resets but wonder if 
> it did open a can of worms?
> 
> Atleast this fixes one iMX6 FEC/RMII/8081 combo.
> 
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Signed-off-by: Christian Melki <christian.melki@...ata.com>

Still does not apply to net/master:

Applying: net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081
error: patch failed: drivers/net/phy/micrel.c:1303
error: drivers/net/phy/micrel.c: patch does not apply
Patch failed at 0001 net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".