netdev - Re: [PATCH net] bcm63xx_enet: fix sporadic kernel panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210223121612.0fda2333@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 23 Feb 2021 12:16:12 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Sieng Piaw Liew <liew.s.piaw@...il.com>, davem@...emloft.net,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] bcm63xx_enet: fix sporadic kernel panic

On Sun, 21 Feb 2021 21:05:50 -0800 Florian Fainelli wrote:
> On 2/21/2021 17:35, Sieng Piaw Liew wrote:
> > In ndo_stop functions, netdev_completed_queue() is called during forced
> > tx reclaim, after netdev_reset_queue(). This may trigger kernel panic if
> > there is any tx skb left.
> > 
> > This patch moves netdev_reset_queue() to after tx reclaim, so BQL can
> > complete successfully then reset.
> > 
> > Signed-off-by: Sieng Piaw Liew <liew.s.piaw@...il.com>  
> 
> Acked-by: Florian Fainelli <f.fainelli@...il.com>
> Fixes: 4c59b0f5543d ("bcm63xx_enet: add BQL support")

Applied, thanks!