netdev - Re: [PATCH net] ethtool: fix the check logic of at least one channel for RX/TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Feb 2021 17:21:11 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     Simon Horman <simon.horman@...ronome.com>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        oss-drivers@...ronome.com,
        Yinjun Zhang <yinjun.zhang@...igine.com>,
        Louis Peens <louis.peens@...ronome.com>
Subject: Re: [PATCH net] ethtool: fix the check logic of at least one
 channel for RX/TX

On Tue, 23 Feb 2021 17:02:06 -0800 Jakub Kicinski wrote:
> On Wed, 24 Feb 2021 01:32:51 +0100 Michal Kubecek wrote:
> > On Tue, Feb 23, 2021 at 02:24:40PM +0100, Simon Horman wrote:  
> > > From: Yinjun Zhang <yinjun.zhang@...igine.com>
> > > 
> > > The command "ethtool -L <intf> combined 0" may clean the RX/TX channel
> > > count and skip the error path, since the attrs
> > > tb[ETHTOOL_A_CHANNELS_RX_COUNT] and tb[ETHTOOL_A_CHANNELS_TX_COUNT]
> > > are NULL in this case when recent ethtool is used.
> > > 
> > > Tested using ethtool v5.10.
> > > 
> > > Fixes: 7be92514b99c ("ethtool: check if there is at least one channel for TX/RX in the core")
> > > Signed-off-by: Yinjun Zhang <yinjun.zhang@...igine.com>
> > > Signed-off-by: Simon Horman <simon.horman@...ronome.com>
> > > Signed-off-by: Louis Peens <louis.peens@...ronome.com>    
> > 
> > Reviewed-by: Michal Kubecek <mkubecek@...e.cz>  
> 
> IOW you prefer this to what I proposed?

Hah, now I missed your email :)