netdev - RE: [PATCH V1 net-next 1/3] net: stmmac: add clocks management for gmac driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB8PR04MB6795B3804780DB7EF0BDFF5DE69F9@DB8PR04MB6795.eurprd04.prod.outlook.com>
Date:   Wed, 24 Feb 2021 01:46:28 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "alexandre.torgue@...com" <alexandre.torgue@...com>,
        "joabreu@...opsys.com" <joabreu@...opsys.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V1 net-next 1/3] net: stmmac: add clocks management for
 gmac driver



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: 2021年2月24日 0:46
> To: Joakim Zhang <qiangqing.zhang@....com>
> Cc: peppe.cavallaro@...com; alexandre.torgue@...com;
> joabreu@...opsys.com; davem@...emloft.net; netdev@...r.kernel.org;
> dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH V1 net-next 1/3] net: stmmac: add clocks management for
> gmac driver
> 
> On Tue, 23 Feb 2021 18:48:16 +0800 Joakim Zhang wrote:
> > +static int stmmac_bus_clks_enable(struct stmmac_priv *priv, bool
> > +enabled)
> 
> nit: my personal preference is to not call functions .._enable() and then make
> them have a parameter saying if it's enable or disable.
> Call the function .._config() or .._set() or such.

OK, thanks, will improve it.

Best Regards,
Joakim Zhang