netdev - Re: [PATCH net] selftest/bpf: no need to drop the packet when there is no geneve opt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALDO+SaW9UxeVjCTPPG5p9bMd+WbjnCW=PMsQOdbN6VNcn+UQQ@mail.gmail.com>
Date:   Wed, 24 Feb 2021 11:17:09 -0800
From:   William Tu <u9012063@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Yi-Hung Wei <yihung.wei@...il.com>,
        David Miller <davem@...emloft.net>, bpf <bpf@...r.kernel.org>,
        Jiong Wang <jiong.wang@...ronome.com>
Subject: Re: [PATCH net] selftest/bpf: no need to drop the packet when there
 is no geneve opt

On Wed, Feb 24, 2021 at 12:37 AM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> In bpf geneve tunnel test we set geneve option on tx side. On rx side we
> only call bpf_skb_get_tunnel_opt(). Since commit 9c2e14b48119 ("ip_tunnels:
> Set tunnel option flag when tunnel metadata is present") geneve_rx() will
> not add TUNNEL_GENEVE_OPT flag if there is no geneve option, which cause
> bpf_skb_get_tunnel_opt() return ENOENT and _geneve_get_tunnel() in
> test_tunnel_kern.c drop the packet.
>
> As it should be valid that bpf_skb_get_tunnel_opt() return error when
> there is not tunnel option, there is no need to drop the packet and
> break all geneve rx traffic. Just set opt_class to 0 in this test and
> keep returning TC_ACT_OK.
>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---

LGTM.
Acked-by: William Tu <u9012063@...il.com>