netdev - Re: [PATCH net 0/7] wireguard fixes for 5.12-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210223160221.02e365b6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 23 Feb 2021 16:02:21 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net 0/7] wireguard fixes for 5.12-rc1

On Mon, 22 Feb 2021 17:25:42 +0100 Jason A. Donenfeld wrote:
> This series has a collection of fixes that have piled up for a little
> while now, that I unfortunately didn't get a chance to send out earlier.
> 
> 1) Removes unlikely() from IS_ERR(), since it's already implied.
> 
> 2) Remove a bogus sparse annotation that hasn't been needed for years.
> 
> 3) Addition test in the test suite for stressing parallel ndo_start_xmit.
> 
> 4) Slight struct reordering in preparation for subsequent fix.
> 
> 5) If skb->protocol is bogus, we no longer attempt to send icmp messages.
> 
> 6) Massive memory usage fix, hit by larger deployments.
> 
> 7) Fix typo in kconfig dependency logic.
> 
> (1) and (2) are tiny cleanups, and (3) is just a test, so if you're
> trying to reduce churn, you could not backport these. But (4), (5), (6),
> and (7) fix problems and should be applied to stable. IMO, it's probably
> easiest to just apply them all to stable.

Preferably 1, 2, 4 and 6 should go into net-next first, and not be
posted half way through the merge window, but I trust you had them 
well tested so applied, thanks!