netdev - Re: [RFC V2 net-next 1/3] net: stmmac: add clocks management for gmac driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YDemoDbVIfblk2u+@lunn.ch>
Date:   Thu, 25 Feb 2021 14:31:12 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Joakim Zhang <qiangqing.zhang@....com>
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, davem@...emloft.net, kuba@...nel.org,
        f.fainelli@...il.com, linux-imx@....com, netdev@...r.kernel.org
Subject: Re: [RFC V2 net-next 1/3] net: stmmac: add clocks management for
 gmac driver

> @@ -248,9 +296,15 @@ static int stmmac_mdio_write(struct mii_bus *bus, int phyaddr, int phyreg,
>  	unsigned int mii_address = priv->hw->mii.addr;
>  	unsigned int mii_data = priv->hw->mii.data;
>  	u32 value = MII_BUSY;
> -	int data = phydata;
> +	int ret, data = phydata;
>  	u32 v;

Reverse Christmass tree.

Otherwise this looks good.

	  Andrew