lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210225095216.73a7d799@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 25 Feb 2021 09:52:16 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>,
        Christian Melki <christian.melki@...ata.com>
Cc:     hkallweit1@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v3 net] net: phy: micrel: set soft_reset callback to
 genphy_soft_reset for KSZ8081

On Thu, 25 Feb 2021 02:59:51 +0100 Andrew Lunn wrote:
> On Wed, Feb 24, 2021 at 09:55:36PM +0100, Christian Melki wrote:
> > Following a similar reinstate for the KSZ9031.
> > 
> > Older kernels would use the genphy_soft_reset if the PHY did not implement
> > a .soft_reset.
> > 
> > Bluntly removing that default may expose a lot of situations where various
> > PHYs/board implementations won't recover on various changes.
> > Like with this implementation during a 4.9.x to 5.4.x LTS transition.
> > I think it's a good thing to remove unwanted soft resets but wonder if it
> > did open a can of worms?
> > 
> > Atleast this fixes one iMX6 FEC/RMII/8081 combo.
> > 
> > Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> > Signed-off-by: Christian Melki <christian.melki@...ata.com>  
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Applied, thanks!

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ