netdev - [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210225005406.530767-1-punit1.agrawal@toshiba.co.jp>
Date:   Thu, 25 Feb 2021 09:54:06 +0900
From:   Punit Agrawal <punit1.agrawal@...hiba.co.jp>
To:     stable@...r.kernel.org
Cc:     netdev@...r.kernel.org, jesse.brandeburg@...el.com,
        anthony.l.nguyen@...el.com, daichi1.fukui@...hiba.co.jp,
        nobuhiro1.iwamatsu@...hiba.co.jp,
        Corinna Vinschen <vinschen@...hat.com>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Aaron Brown <aaron.f.brown@...el.com>
Subject: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

From: Corinna Vinschen <vinschen@...hat.com>

commit 2643e6e90210e16c978919617170089b7c2164f7 upstream

TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP
every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000
secs on 80576 (45 bit SYSTIM).

This wrap event sets the TSICR.SysWrap bit unconditionally.

However, checking TSIM at interrupt time shows that this event does not
actually cause the interrupt.  Rather, it's just bycatch while the
actual interrupt is caused by, for instance, TSICR.TXTS.

The conclusion is that the SYS WRAP is actually expected, so the
"unexpected SYS WRAP" message is entirely bogus and just helps to
confuse users.  Drop it.

Signed-off-by: Corinna Vinschen <vinschen@...hat.com>
Acked-by: Jacob Keller <jacob.e.keller@...el.com>
Tested-by: Aaron Brown <aaron.f.brown@...el.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
---
[ Due to confusion about stable rules for networking the request was
mistakenly sent to netdev only[0]. Apologies if you're seeing this
again. ]

Hi,

A customer reported that the following message appears in the kernel
logs every 1100s -

    igb 0000:01:00.1: unexpected SYS WRAP

As the systems have large uptimes the messages are crowding the logs.

The message was dropped in 
commit 2643e6e90210e16c ("igb: Remove incorrect "unexpected SYS WRAP" log message")
in v4.14.

Please consider applying to patch to v4.4 and v4.9 stable kernels - it
applies cleanly to both the trees.

Thanks,
Punit

[0] https://lore.kernel.org/netdev/20210210013448.2116413-1-punit1.agrawal@toshiba.co.jp/

 drivers/net/ethernet/intel/igb/igb_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index a4aa4d10ca70..682f52760898 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -5421,8 +5421,6 @@ static void igb_tsync_interrupt(struct igb_adapter *adapter)
 		event.type = PTP_CLOCK_PPS;
 		if (adapter->ptp_caps.pps)
 			ptp_clock_event(adapter->ptp_clock, &event);
-		else
-			dev_err(&adapter->pdev->dev, "unexpected SYS WRAP");
 		ack |= TSINTR_SYS_WRAP;
 	}

-- 
2.29.2