netdev - Re: [PATCH net-next 1/4] net: dsa: don't offload switchdev objects on ports that don't offload the bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Feb 2021 20:23:38 +0100
From:   Tobias Waldekranz <tobias@...dekranz.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com, Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        George McCollister <george.mccollister@...il.com>,
        DENG Qingfang <dqfext@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        Rasmus Villemoes <rasmus.villemoes@...vas.dk>,
        Oleksij Rempel <linux@...pel-privat.de>
Subject: Re: [PATCH net-next 1/4] net: dsa: don't offload switchdev objects on ports that don't offload the bridge

On Sun, Feb 14, 2021 at 17:53, Vladimir Oltean <olteanv@...il.com> wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
>
> Starting with commit 058102a6e9eb ("net: dsa: Link aggregation support"),
> DSA warns that certain configurations of upper interfaces are not offloaded
> to hardware. When a DSA port does not offload a LAG interface, the
> dp->lag_dev pointer is always NULL. However the same cannot be said about
> offloading a bridge: dp->bridge_dev will get populated regardless of
> whether the driver can put the port into the bridge's forwarding domain
> or not.
>
> Instead of silently returning 0 if the driver doesn't implement
> .port_bridge_join, return -EOPNOTSUPP instead, and print a message via
> netlink extack that the configuration was not offloaded to hardware.
>
> Now we can use the check whether dp->bridge_dev is NULL in order to
> avoid offloading at all switchdev attributes and objects for ports that
> don't even offload the basic operation of switching. Those can still do
> the required L2 forwarding using the bridge software datapath, but
> enabling any hardware features specific to the bridge such as address
> learning would just ask for problems.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---

Reviewed-by: Tobias Waldekranz <tobias@...dekranz.com>