netdev - Re: [PATCH net 6/6] net: enetc: force the RGMII speed and duplex instead of operating in inband mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210225112942.GT1463@shell.armlinux.org.uk>
Date:   Thu, 25 Feb 2021 11:29:42 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Michael Walle <michael@...le.cc>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandru Marginean <alexandru.marginean@....com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net 6/6] net: enetc: force the RGMII speed and duplex
 instead of operating in inband mode

On Thu, Feb 25, 2021 at 01:23:57PM +0200, Vladimir Oltean wrote:
>  static void enetc_pl_mac_link_up(struct phylink_config *config,
>  				 struct phy_device *phy, unsigned int mode,
>  				 phy_interface_t interface, int speed,
> @@ -945,6 +981,10 @@ static void enetc_pl_mac_link_up(struct phylink_config *config,
>  		enetc_sched_speed_set(priv, speed);
>  
>  	enetc_mac_enable(&pf->si->hw, true);
> +
> +	if (!phylink_autoneg_inband(mode) &&
> +	    phy_interface_mode_is_rgmii(interface))
> +		enetc_force_rgmii_mac(&pf->si->hw, speed, duplex);

Does it matter that you're forcing the RGMII setup after having enabled
the MAC?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!