netdev - Re: [PATCH bpf-next v2 0/5] PROG_TEST_RUN support for sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQJi_==XB8=PdqfOa24HfSAcyaasnbZCzxvbcOtCWaP7EQ@mail.gmail.com>
Date:   Fri, 26 Feb 2021 12:55:01 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Lorenz Bauer <lmb@...udflare.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        kernel-team <kernel-team@...udflare.com>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next v2 0/5] PROG_TEST_RUN support for sk_lookup programs

On Fri, Feb 26, 2021 at 2:31 AM Lorenz Bauer <lmb@...udflare.com> wrote:
>
> We don't have PROG_TEST_RUN support for sk_lookup programs at the
> moment. So far this hasn't been a problem, since we can run our
> tests in a separate network namespace. For benchmarking it's nice
> to have PROG_TEST_RUN, so I've gone and implemented it.
>
> Based on discussion on the v1 I've dropped support for testing multiple
> programs at once.
>
> Changes since v1:
> - Add sparse annotations to the t_* functions
> - Add appropriate type casts in bpf_prog_test_run_sk_lookup
> - Drop running multiple programs

Looks good.
I applied it, but then reverted since test_verifier needs to be adjusted:
./test_verifier 349
#349/p valid 1,2,4,8-byte reads from bpf_sk_lookup FAIL: Unexpected
bpf_prog_test_run error (Invalid argument) (run 1/1)

That's the only test that has ACCEPT for sk_lookup prog type
and the framework now is trying to run it.
Pls respin.