netdev - Re: [PATCH/v3] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Feb 2021 16:29:21 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Xuesen Huang <hxseverything@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Miller <davem@...emloft.net>, bpf <bpf@...r.kernel.org>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Xuesen Huang <huangxuesen@...ishou.com>,
        Zhiyong Cheng <chengzhiyong@...ishou.com>,
        Li Wang <wangli09@...ishou.com>
Subject: Re: [PATCH/v3] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

On Fri, Feb 26, 2021 at 3:15 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> On Thu, Feb 25, 2021 at 7:59 PM Xuesen Huang <hxseverything@...il.com> wrote:
> > v3:
> > - Fix the code format.
> >
> > v2:
> > Suggested-by: Willem de Bruijn <willemb@...gle.com>
> > - Add a new flag to specify the type of the inner packet.
>
> These need to be moved after '---', otherwise it would be merged
> into the final git log.
>
> >
> > Suggested-by: Willem de Bruijn <willemb@...gle.com>
> > Signed-off-by: Xuesen Huang <huangxuesen@...ishou.com>
> > Signed-off-by: Zhiyong Cheng <chengzhiyong@...ishou.com>
> > Signed-off-by: Li Wang <wangli09@...ishou.com>
> > ---
> >  include/uapi/linux/bpf.h       |  5 +++++
> >  net/core/filter.c              | 11 ++++++++++-
> >  tools/include/uapi/linux/bpf.h |  5 +++++
> >  3 files changed, 20 insertions(+), 1 deletion(-)
>
> As a good practice, please add a test case for this in
> tools/testing/selftests/bpf/progs/test_tc_tunnel.c.

That's a great idea. This function covers a lot of cases. Can use the
code coverage against regressions.

With that caveat, looks great to me, thanks.