netdev - Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Feb 2021 17:14:08 +0100
From:   Daniel González Cabanelas <dgcbueu@...il.com>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, gregkh@...uxfoundation.org,
        netdev@...r.kernel.org,
        Álvaro Fernández Rojas <noltari@...il.com>
Subject: Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

I could update the BCM5365 phy_id in the downstream B53 driver to fix
it and avoid any kind of future conflicts if the driver is upstreamed.
Accordingly to documentation the whole BCM5365 UID (not masked) is
0x00406370.
PHYID HIGH[15:0] = OUI[21:6]
PHYID LOW[15:0] = OUI[5:0] + MODEL[5:0] + REV[3:0]

Right now the used mask is 0x1ffffc00. But if I understood correctly
it is only required to mask the last 3 bits. This would reflect in the
B53 driver:
---snip---
/* BCM5365 */
static struct phy_driver b53_phy_driver_id3 = {
.phy_id = 0x00406370,
.name = "Broadcom B53 (3)",
.phy_id_mask = 0xfffffff8,,
----snip---

For the tested board, BCM6348, the UID is 0x00406240 (read by the
kernel). But in this case its driver involves more SoCs/PHYs, maybe
with different UIDs.

Regards

El vie, 26 feb 2021 a las 15:28, Heiner Kallweit
(<hkallweit1@...il.com>) escribió:
>
> On 26.02.2021 15:16, Andrew Lunn wrote:
> >>> OK, I see. Then there's no reason to complain upstream.
> >>> Either use the mainline B53 DSA driver of fix interrupt mode
> >>> downstream.
> >>
> >> I agree.
> >>
> >> This b53 driver has one PHY with the same BCM63XX phy_id, causing a
> >> double probe. I'll send the original patch to the OpenWrt project.
> >
> > Hi Daniel
> >
> > There is a bit of a disconnect between OpenWRT and Mainline. They have
> > a lot of fixes that don't make it upstream. So it is good to see
> > somebody trying to fix mainline first, and then backport to
> > OpenWRT. But please do test mainline and confirm it is actually broken
> > before submitting patches.
> >
> > When you do submit to OpenWRT, please make it clear this is an OpenWRT
> > problem so somebody does not try to push it to mainline again....
> >
> > And if you have an itch to scratch, try adding mainline support for
> > this board. We can guide you.
> >
> Daniel has two conflicting PHY drivers for bcm63xx, the one from mainline,
> and one in the OpenWRT downstream b53 driver. Removing the mainline
> PHY driver would resolve the conflict, but the OpenWRT PHY driver has
> no IRQ support so Daniel would gain nothing.
> I think best would be to remove the duplicated PHY driver from the
> OpenWRT b53 driver. Daniel could try to remove b53_phy_driver_id3 and
> re-test.
>
> >       Andrew
> >
> Heiner