netdev - Re: [RFC net-next 1/2] net: dsa: add Realtek RTL8366S switch tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaP9RGX9OY2s1fqkZJD0fc3jtZ4_R4A7VvL0=po-KEqyQ@mail.gmail.com>
Date:   Sun, 28 Feb 2021 00:47:17 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     DENG Qingfang <dqfext@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Mauri Sandberg <sandberg@...lfence.com>
Subject: Re: [RFC net-next 1/2] net: dsa: add Realtek RTL8366S switch tag

On Wed, Feb 17, 2021 at 7:21 AM DENG Qingfang <dqfext@...il.com> wrote:

> Add support for Realtek RTL8366S switch tag
>
> Signed-off-by: DENG Qingfang <dqfext@...il.com>

I understand this switch tag now sorry for confusion.

> @@ -104,6 +104,12 @@ config NET_DSA_TAG_RTL4_A
>           Realtek switches with 4 byte protocol A tags, sich as found in
>           the Realtek RTL8366RB.
>
> +config NET_DSA_TAG_RTL8366S
> +       tristate "Tag driver for Realtek RTL8366S switch tags"
> +       help
> +         Say Y or M if you want to enable support for tagging frames for the
> +         Realtek RTL8366S switch.

I names the previous protocol "RTL4 A" after a 4-byte tag
with protocol indicted as "A", what about naming this
"RTL2 9" in the same vein? It will be good if some other
switch is using the same protocol. (If any...)

>  obj-$(CONFIG_NET_DSA_TAG_RTL4_A) += tag_rtl4_a.o
> +obj-$(CONFIG_NET_DSA_TAG_RTL8366S) += tag_rtl8366s.o

So tag_rtl2_9.o etc.

Yours,
Linus Walleij