netdev - Re: [PATCH net] net: broadcom: bcm4908_enet: enable RX after processing packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210228115422.490b7e5c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sun, 28 Feb 2021 11:54:22 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Rafał Miłecki <zajec5@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH net] net: broadcom: bcm4908_enet: enable RX after
 processing packets

On Sat, 27 Feb 2021 08:38:24 -0800 Florian Fainelli wrote:
> On 2/26/2021 5:20 AM, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@...ecki.pl>
> > 
> > When receiving a lot of packets hardware may run out of free
> > descriptiors and stop RX ring. Enable it every time after handling
> > received packets.
> > 
> > Fixes: 4feffeadbcb2 ("net: broadcom: bcm4908enet: add BCM4908 controller driver")
> > Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>  
> 
> Acked-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks!

Out of curiosity - is the performance not impacted by this change?
bcm4908_enet_dma_rx_ring_enable() does an RMW, the read could possibly
removed by caching the expected value.