netdev - Re: [PATCH rdma-next] RDMA: Support more than 255 rdma ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 Mar 2021 16:44:45 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Jason Gunthorpe <jgg@...dia.com>
Cc:     Doug Ledford <dledford@...hat.com>, Mark Bloch <mbloch@...dia.com>,
        Adit Ranadive <aditr@...are.com>,
        Ariel Elior <aelior@...vell.com>,
        Bart Van Assche <bvanassche@....org>,
        Bernard Metzler <bmt@...ich.ibm.com>,
        Christian Benvenuti <benve@...co.com>,
        Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
        Devesh Sharma <devesh.sharma@...adcom.com>,
        Faisal Latif <faisal.latif@...el.com>,
        Gal Pressman <galpress@...zon.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Lijun Ou <oulijun@...wei.com>, linux-rdma@...r.kernel.org,
        Michal Kalderon <mkalderon@...vell.com>,
        Mike Marciniszyn <mike.marciniszyn@...nelisnetworks.com>,
        Naresh Kumar PBS <nareshkumar.pbs@...adcom.com>,
        Nelson Escobar <neescoba@...co.com>, netdev@...r.kernel.org,
        Potnuri Bharat Teja <bharat@...lsio.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        Selvin Xavier <selvin.xavier@...adcom.com>,
        Shiraz Saleem <shiraz.saleem@...el.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
        target-devel@...r.kernel.org,
        VMware PV-Drivers <pv-drivers@...are.com>,
        Weihang Li <liweihang@...wei.com>,
        "Wei Hu(Xavier)" <huwei87@...ilicon.com>,
        Yishai Hadas <yishaih@...dia.com>,
        Zhu Yanjun <zyjzyj2000@...il.com>
Subject: Re: [PATCH rdma-next] RDMA: Support more than 255 rdma ports

On Mon, Mar 01, 2021 at 08:48:34AM -0400, Jason Gunthorpe wrote:
> On Mon, Mar 01, 2021 at 09:04:20AM +0200, Leon Romanovsky wrote:
> > @@ -884,7 +884,7 @@ static void gid_table_reserve_default(struct ib_device *ib_dev, u8 port,
> >
> >  static void gid_table_release_one(struct ib_device *ib_dev)
> >  {
> > -	unsigned int p;
> > +	u32 p;
> >
> >  	rdma_for_each_port (ib_dev, p) {
> >  		release_gid_table(ib_dev, ib_dev->port_data[p].cache.gid);
> > @@ -895,7 +895,7 @@ static void gid_table_release_one(struct ib_device *ib_dev)
> >  static int _gid_table_setup_one(struct ib_device *ib_dev)
> >  {
> >  	struct ib_gid_table *table;
> > -	unsigned int rdma_port;
> > +	u32 rdma_port;
> >
> >  	rdma_for_each_port (ib_dev, rdma_port) {
>
> Why are we changing this? 'unsigned int' is the right type for port
> numbers

I prefer to see same types in all places. We use u32 for HW data and
netlink, so it makes sense to have it everywhere. Also, at least for me,
the u32 is more explicit than "unsigned int".

So when Mark asked me which type to use, I said u32.

Thanks

>
> Jason