netdev - RE: [Patch bpf-next] skmsg: add function doc for skb->_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <603d386fcb3e8_20893c208c5@john-XPS-13-9370.notmuch>
Date:   Mon, 01 Mar 2021 10:54:39 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Cc:     bpf@...r.kernel.org, Cong Wang <cong.wang@...edance.com>,
        Lorenz Bauer <lmb@...udflare.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        John Fastabend <john.fastabend@...il.com>,
        Jakub Sitnicki <jakub@...udflare.com>
Subject: RE: [Patch bpf-next] skmsg: add function doc for skb->_sk_redir

Cong Wang wrote:
> From: Cong Wang <cong.wang@...edance.com>
> 
> This should fix the following warning:
> 
> include/linux/skbuff.h:932: warning: Function parameter or member
> '_sk_redir' not described in 'sk_buff'
> 
> Reported-by: Lorenz Bauer <lmb@...udflare.com>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: John Fastabend <john.fastabend@...il.com>
> Cc: Jakub Sitnicki <jakub@...udflare.com>
> Signed-off-by: Cong Wang <cong.wang@...edance.com>
> ---
>  include/linux/skbuff.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index bd84f799c952..0503c917d773 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -656,6 +656,7 @@ typedef unsigned char *sk_buff_data_t;
>   *	@protocol: Packet protocol from driver
>   *	@destructor: Destruct function
>   *	@tcp_tsorted_anchor: list structure for TCP (tp->tsorted_sent_queue)
> + *	@_sk_redir: socket redirection information for skmsg
>   *	@_nfct: Associated connection, if any (with nfctinfo bits)
>   *	@nf_bridge: Saved data about a bridged frame - see br_netfilter.c
>   *	@skb_iif: ifindex of device we arrived on
> -- 
> 2.25.1
> 

Acked-by: John Fastabend <john.fastabend@...il.com>