netdev - Re: [Patch bpf-next v2 5/9] udp: add ->read_sock() and ->sendmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Mar 2021 09:59:23 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Lorenz Bauer <lmb@...udflare.com>
Cc:     Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        duanxiongchun@...edance.com,
        Dongdong Wang <wangdongdong.6@...edance.com>,
        Jiang Wang <jiang.wang@...edance.com>,
        Cong Wang <cong.wang@...edance.com>,
        John Fastabend <john.fastabend@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jakub Sitnicki <jakub@...udflare.com>
Subject: Re: [Patch bpf-next v2 5/9] udp: add ->read_sock() and
 ->sendmsg_locked() to ipv6

On Tue, Mar 2, 2021 at 8:23 AM Lorenz Bauer <lmb@...udflare.com> wrote:
>
> On Tue, 2 Mar 2021 at 02:38, Cong Wang <xiyou.wangcong@...il.com> wrote:
> > diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
> > index 54f24b1d4f65..717c543aaec3 100644
> > --- a/net/ipv4/udp.c
> > +++ b/net/ipv4/udp.c
> > @@ -1831,6 +1831,7 @@ int udp_read_sock(struct sock *sk, read_descriptor_t *desc,
> >
> >         return copied;
> >  }
> > +EXPORT_SYMBOL(udp_read_sock);
>
> Should this be in the previous commit?

No, exporting this symbol is unnecessary until a module starts to
use it, which is IPv6 module in this patch. So, it is perfectly fine to
export it here.

Thanks.