netdev - Re: [PATCH net 1/3] sh_eth: fix TRSCER mask for SH771x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVgasQPwQRsoi3nc6jqBaL7yhwBoyo7feac=f7dLnz5Uw@mail.gmail.com>
Date:   Thu, 4 Mar 2021 09:42:44 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Sergey Shtylyov <s.shtylyov@...russia.ru>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH net 1/3] sh_eth: fix TRSCER mask for SH771x

On Sun, Feb 28, 2021 at 9:54 PM Sergey Shtylyov <s.shtylyov@...russia.ru> wrote:
> According  to  the SH7710, SH7712, SH7713 Group User's Manual: Hardware,
> Rev. 3.00, the TRSCER register actually has only bit 7 valid (and named
> differently), with all the other bits reserved. Apparently, this was not
> the case with some early revisions of the manual as we have the other
> bits declared (and set) in the original driver.  Follow the suit and add
> the explicit sh_eth_cpu_data::trscer_err_mask initializer for SH771x...
>
> Fixes: 86a74ff21a7a ("net: sh_eth: add support for Renesas SuperH Ethernet")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@...russia.ru>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds