netdev - Re: [PATCH] net/mlx5: use kvfree() for memory allocated with kvzalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Mar 2021 09:54:52 +0200
From:   Roi Dayan <roid@...dia.com>
To:     angkery <angkery@....com>, <saeedm@...dia.com>, <leon@...nel.org>,
        <davem@...emloft.net>, <kuba@...nel.org>, <vladbu@...dia.com>,
        <dlinkin@...dia.com>, <dan.carpenter@...cle.com>
CC:     <netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Junlin Yang <yangjunlin@...ong.com>
Subject: Re: [PATCH] net/mlx5: use kvfree() for memory allocated with
 kvzalloc()



On 2021-03-03 4:40 AM, angkery wrote:
> From: Junlin Yang <yangjunlin@...ong.com>
> 
> It is allocated with kvzalloc(), the corresponding release function
> should not be kfree(), use kvfree() instead.
> 
> Generated by: scripts/coccinelle/api/kfree_mismatch.cocci
> 
> Signed-off-by: Junlin Yang <yangjunlin@...ong.com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> index 6f6772b..3da7bec 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> @@ -248,7 +248,7 @@ static int mlx5_esw_indir_table_rule_get(struct mlx5_eswitch *esw,
>   err_ethertype:
>   	kfree(rule);
>   out:
> -	kfree(rule_spec);
> +	kvfree(rule_spec);
>   	return err;
>   }
>   
> @@ -328,7 +328,7 @@ static int mlx5_create_indir_recirc_group(struct mlx5_eswitch *esw,
>   	e->recirc_cnt = 0;
>   
>   out:
> -	kfree(in);
> +	kvfree(in);
>   	return err;
>   }
>   
> @@ -347,7 +347,7 @@ static int mlx5_create_indir_fwd_group(struct mlx5_eswitch *esw,
>   
>   	spec = kvzalloc(sizeof(*spec), GFP_KERNEL);
>   	if (!spec) {
> -		kfree(in);
> +		kvfree(in);
>   		return -ENOMEM;
>   	}
>   
> @@ -371,8 +371,8 @@ static int mlx5_create_indir_fwd_group(struct mlx5_eswitch *esw,
>   	}
>   
>   err_out:
> -	kfree(spec);
> -	kfree(in);
> +	kvfree(spec);
> +	kvfree(in);
>   	return err;
>   }
>   
> 

thanks!

Reviewed-by: Roi Dayan <roid@...dia.com>