netdev - Re: next-20210302 - build issue with linux-firmware and rtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <205633.1614757174@turing-police>
Date:   Wed, 03 Mar 2021 02:39:34 -0500
From:   "Valdis Klētnieks" <valdis.kletnieks@...edu>
To:     Heiner Kallweit <hkallweit1@...il.com>
cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: next-20210302 - build issue with linux-firmware and rtl_nic/ firmware.

On Wed, 03 Mar 2021 07:51:06 +0100, Heiner Kallweit said:
> > # Firmware loader
> > CONFIG_EXTRA_FIRMWARE="rtl_nic/rtl8106e-1.fw"
> > CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware"
> > 
> This is wrong, simply remove it.

> > But then I take a closer look at  drivers/net/ethernet/realtek/r8169_main.c
> > #define FIRMWARE_8168D_1	"rtl_nic/rtl8168d-1.fw"
> > #define FIRMWARE_8168D_2	"rtl_nic/rtl8168d-2.fw"
> > #define FIRMWARE_8168E_1	"rtl_nic/rtl8168e-1.fw"

Yes, but then how are *these* filenames supposed to work? Is a userspace helper
supposed to be smart enough to append the .xz, and the EXTRA_FIRMWARE variant
for embedding out-of-tree firmware has to point at an uncompressed version?