netdev - Re: [RFC PATCH v5 19/19] virtio/vsock: update trace event for SEQPACKET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c80f403d-9fec-dd78-bb91-44c9e0bd74a2@kaspersky.com>
Date:   Wed, 3 Mar 2021 13:42:20 +0300
From:   Arseny Krasnov <arseny.krasnov@...persky.com>
To:     Steven Rostedt <rostedt@...dmis.org>
CC:     Stefan Hajnoczi <stefanha@...hat.com>,
        Stefano Garzarella <sgarzare@...hat.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Jorgen Hansen <jhansen@...are.com>,
        Norbert Slusarek <nslusarek@....net>,
        Andra Paraschiv <andraprs@...zon.com>,
        Colin Ian King <colin.king@...onical.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stsp2@...dex.ru" <stsp2@...dex.ru>,
        "oxffffaa@...il.com" <oxffffaa@...il.com>
Subject: Re: [RFC PATCH v5 19/19] virtio/vsock: update trace event for
 SEQPACKET


On 03.03.2021 01:25, Steven Rostedt wrote:
> On Thu, 18 Feb 2021 08:42:15 +0300
> Arseny Krasnov <arseny.krasnov@...persky.com> wrote:
>
> Not sure if this was pulled in yet, but I do have a small issue with this
> patch.
No, it is in RFC state.
>
>> @@ -69,14 +82,19 @@ TRACE_EVENT(virtio_transport_alloc_pkt,
>>  		__entry->type = type;
>>  		__entry->op = op;
>>  		__entry->flags = flags;
>> +		__entry->msg_len = msg_len;
>> +		__entry->msg_cnt = msg_cnt;
>>  	),
>> -	TP_printk("%u:%u -> %u:%u len=%u type=%s op=%s flags=%#x",
>> +	TP_printk("%u:%u -> %u:%u len=%u type=%s op=%s flags=%#x "
>> +		  "msg_len=%u msg_cnt=%u",
> It's considered poor formatting to split strings like the above. This is
> one of the exceptions for the 80 character limit. Do not break strings just
> to keep it within 80 characters.
>
> -- Steve
Ok, will fix in next version, Thank You
>
>
>>  		  __entry->src_cid, __entry->src_port,
>>  		  __entry->dst_cid, __entry->dst_port,
>>  		  __entry->len,
>>  		  show_type(__entry->type),
>>  		  show_op(__entry->op),
>> -		  __entry->flags)
>> +		  __entry->flags,
>> +		  __entry->msg_len,
>> +		  __entry->msg_cnt)
>>  );