netdev - Re: [PATCH net] r8169: fix r8168fp_adjust_ocp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Mar 2021 12:48:18 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Hayes Wang <hayeswang@...ltek.com>
Cc:     nic_swsd@...ltek.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] r8169: fix r8168fp_adjust_ocp_cmd function

On 05.03.2021 10:34, Hayes Wang wrote:
> The (0xBAF70000 & 0x00FFF000) << 6 should be (0xf70 << 18).
> 
> Fixes: 561535b0f239 ("r8169: fix OCP access on RTL8117")
> Signed-off-by: Hayes Wang <hayeswang@...ltek.com>
> ---
>  drivers/net/ethernet/realtek/r8169_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index f704da3f214c..7aad0ba53372 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -767,7 +767,7 @@ static void r8168fp_adjust_ocp_cmd(struct rtl8169_private *tp, u32 *cmd, int typ
>  	if (type == ERIAR_OOB &&
>  	    (tp->mac_version == RTL_GIGA_MAC_VER_52 ||
>  	     tp->mac_version == RTL_GIGA_MAC_VER_53))
> -		*cmd |= 0x7f0 << 18;
> +		*cmd |= 0xf70 << 18;
>  }
>  
>  DECLARE_RTL_COND(rtl_eriar_cond)
> 
Acked-by: Heiner Kallweit <hkallweit1@...il.com>