netdev - Re: [PATCH bpf] veth: store queue_mapping independently of XDP prog presence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c05a530-633b-03ce-2362-8dc9d5a76d98@gmail.com>
Date:   Fri, 5 Mar 2021 23:50:23 +0900
From:   Toshiaki Makita <toshiaki.makita1@...il.com>
To:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        makita.toshiaki@....ntt.co.jp, daniel@...earbox.net,
        ast@...nel.org, bpf@...r.kernel.org, netdev@...r.kernel.org
Cc:     bjorn.topel@...el.com, magnus.karlsson@...el.com
Subject: Re: [PATCH bpf] veth: store queue_mapping independently of XDP prog
 presence

On 2021/03/04 0:29, Maciej Fijalkowski wrote:
> Currently, veth_xmit() would call the skb_record_rx_queue() only when
> there is XDP program loaded on peer interface in native mode.
> 
> If peer has XDP prog in generic mode, then netif_receive_generic_xdp()
> has a call to netif_get_rxqueue(skb), so for multi-queue veth it will
> not be possible to grab a correct rxq.
> 
> To fix that, store queue_mapping independently of XDP prog presence on
> peer interface.
> 
> Fixes: 638264dc9022 ("veth: Support per queue XDP ring")
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>

I did like this in order to keep the default behavior for non-xdp case,
but generic XDP should behave the same as native XDP, so

Acked-by: Toshiaki Makita <toshiaki.makita1@...il.com>