netdev - Re: [PATCH net] ethernet: alx: fix order of calls on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210305141930.78fbfac7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 5 Mar 2021 14:19:30 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     davem@...emloft.net
Cc:     netdev@...r.kernel.org, zbynek.michl@...il.com,
        chris.snook@...il.com, bruceshenzk@...il.com,
        stable@...r.kernel.org
Subject: Re: [PATCH net] ethernet: alx: fix order of calls on resume

On Fri,  5 Mar 2021 14:17:29 -0800 Jakub Kicinski wrote:
> netif_device_attach() will unpause the queues so we can't call
> it before __alx_open(). This went undetected until
> commit b0999223f224 ("alx: add ability to allocate and free
> alx_napi structures") but now if stack tries to xmit immediately
> on resume before __alx_open() we'll crash on the NAPI being null:

> Cc: <stable@...r.kernel.org> # 4.9+
> Fixes: bc2bebe8de8e ("alx: remove WoL support")
> Reported-by: Zbynek Michl <zbynek.michl@...il.com>
> Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983595
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

I should have also added:

Tested-by: Zbynek Michl <zbynek.michl@...il.com>