netdev - Re: [PATCH] ibmvnic: remove excessive irqsave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210305041910.GA1396452@us.ibm.com>
Date:   Thu, 4 Mar 2021 20:19:10 -0800
From:   Sukadev Bhattiprolu <sukadev@...ux.ibm.com>
To:     angkery <angkery@....com>
Cc:     mpe@...erman.id.au, benh@...nel.crashing.org, paulus@...ba.org,
        drt@...ux.ibm.com, ljp@...ux.ibm.com, davem@...emloft.net,
        kuba@...nel.org, linuxppc-dev@...ts.ozlabs.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Junlin Yang <yangjunlin@...ong.com>
Subject: Re: [PATCH] ibmvnic: remove excessive irqsave

angkery [angkery@....com] wrote:
> From: Junlin Yang <yangjunlin@...ong.com>
> 
> ibmvnic_remove locks multiple spinlocks while disabling interrupts:
> spin_lock_irqsave(&adapter->state_lock, flags);
> spin_lock_irqsave(&adapter->rwi_lock, flags);
> 
> there is no need for the second irqsave,since interrupts are disabled
> at that point, so remove the second irqsave:
> spin_lock_irqsave(&adapter->state_lock, flags);
> spin_lock(&adapter->rwi_lock);
> 
> Generated by: ./scripts/coccinelle/locks/flags.cocci
> ./drivers/net/ethernet/ibm/ibmvnic.c:5413:1-18:
> ERROR: nested lock+irqsave that reuses flags from line 5404.
> 

Thanks. Please add

Fixes: 4a41c421f367 ("ibmvnic: serialize access to work queue on remove")

> Signed-off-by: Junlin Yang <yangjunlin@...ong.com>

Reviewed-by: Sukadev Bhattiprolu <sukadev@...ux.ibm.com>