netdev - RE: [PATCH v3 bpf-next] bpf: devmap: move drop error path to devmap for XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB5807A0AA3FF233F4ED1042AFF2939@VI1PR04MB5807.eurprd04.prod.outlook.com>
Date:   Mon, 8 Mar 2021 13:46:36 +0000
From:   Camelia Alexandra Groza <camelia.groza@....com>
To:     Lorenzo Bianconi <lorenzo@...nel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "brouer@...hat.com" <brouer@...hat.com>,
        "toke@...hat.com" <toke@...hat.com>,
        "freysteinn.alfredsson@....se" <freysteinn.alfredsson@....se>,
        "lorenzo.bianconi@...hat.com" <lorenzo.bianconi@...hat.com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "mst@...hat.com" <mst@...hat.com>,
        "thomas.petazzoni@...tlin.com" <thomas.petazzoni@...tlin.com>,
        "mw@...ihalf.com" <mw@...ihalf.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "ilias.apalodimas@...aro.org" <ilias.apalodimas@...aro.org>,
        "netanel@...zon.com" <netanel@...zon.com>,
        "akiyano@...zon.com" <akiyano@...zon.com>,
        "michael.chan@...adcom.com" <michael.chan@...adcom.com>,
        Madalin Bucur <madalin.bucur@....com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        "jesse.brandeburg@...el.com" <jesse.brandeburg@...el.com>,
        "anthony.l.nguyen@...el.com" <anthony.l.nguyen@...el.com>,
        "saeedm@...dia.com" <saeedm@...dia.com>,
        "grygorii.strashko@...com" <grygorii.strashko@...com>,
        "ecree.xilinx@...il.com" <ecree.xilinx@...il.com>,
        "maciej.fijalkowski@...el.com" <maciej.fijalkowski@...el.com>
Subject: RE: [PATCH v3 bpf-next] bpf: devmap: move drop error path to devmap
 for XDP_REDIRECT

> -----Original Message-----
> From: Lorenzo Bianconi <lorenzo@...nel.org>
> Sent: Monday, March 8, 2021 13:07
> To: bpf@...r.kernel.org
> Cc: netdev@...r.kernel.org; davem@...emloft.net; kuba@...nel.org;
> ast@...nel.org; daniel@...earbox.net; brouer@...hat.com;
> toke@...hat.com; freysteinn.alfredsson@....se;
> lorenzo.bianconi@...hat.com; john.fastabend@...il.com;
> jasowang@...hat.com; mst@...hat.com; thomas.petazzoni@...tlin.com;
> mw@...ihalf.com; linux@...linux.org.uk; ilias.apalodimas@...aro.org;
> netanel@...zon.com; akiyano@...zon.com;
> michael.chan@...adcom.com; Madalin Bucur <madalin.bucur@....com>;
> Ioana Ciornei <ioana.ciornei@....com>; jesse.brandeburg@...el.com;
> anthony.l.nguyen@...el.com; saeedm@...dia.com;
> grygorii.strashko@...com; ecree.xilinx@...il.com;
> maciej.fijalkowski@...el.com
> Subject: [PATCH v3 bpf-next] bpf: devmap: move drop error path to devmap
> for XDP_REDIRECT
> 
> We want to change the current ndo_xdp_xmit drop semantics because
> it will allow us to implement better queue overflow handling.
> This is working towards the larger goal of a XDP TX queue-hook.
> Move XDP_REDIRECT error path handling from each XDP ethernet driver to
> devmap code. According to the new APIs, the driver running the
> ndo_xdp_xmit pointer, will break tx loop whenever the hw reports a tx
> error and it will just return to devmap caller the number of successfully
> transmitted frames. It will be devmap responsability to free dropped
> frames.
> Move each XDP ndo_xdp_xmit capable driver to the new APIs:
> - veth
> - virtio-net
> - mvneta
> - mvpp2
> - socionext
> - amazon ena
> - bnxt
> - freescale (dpaa2, dpaa)
> - xen-frontend
> - qede
> - ice
> - igb
> - ixgbe
> - i40e
> - mlx5
> - ti (cpsw, cpsw-new)
> - tun
> - sfc
> 
> Acked-by: Edward Cree <ecree.xilinx@...il.com>
> Reviewed-by: Ioana Ciornei <ioana.ciornei@....com>
> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>

For the dpaa driver:
Reviewed-by: Camelia Groza <camelia.groza@....com>