netdev - RE: [PATCH net-next v2 5/6] net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum trailer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Mar 2021 13:53:05 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Alex Elder' <elder@...aro.org>,
        "subashab@...eaurora.org" <subashab@...eaurora.org>,
        "stranche@...eaurora.org" <stranche@...eaurora.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "sharathv@...eaurora.org" <sharathv@...eaurora.org>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "evgreen@...omium.org" <evgreen@...omium.org>,
        "cpratapa@...eaurora.org" <cpratapa@...eaurora.org>,
        "elder@...nel.org" <elder@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next v2 5/6] net: qualcomm: rmnet: don't use C
 bit-fields in rmnet checksum trailer

...
> >> -	if (!csum_trailer->valid) {
> >> +	if (!u8_get_bits(csum_trailer->flags, MAP_CSUM_DL_VALID_FMASK)) {
> >
> > Is that just an overcomplicated way of saying:
> > 	if (!(csum_trailer->flags & MAP_CSUM_DL_VALID_FMASK)) {
> 
> Yes it is.  I defined and used all the field masks in a
> consistent way, but I do think it will read better the
> way you suggest.  Bjorn also asked me privately whether
> GENMASK(15, 15) was just the same as BIT(15) (it is).
> 
> I will post version 3 of the series, identifying which
> fields are single bit/Boolean.  For those I will define
> the value using BIT() and will set/extract using simple
> AND/OR operators.  I won't use the _FMASK suffix on such
> fields.

Even for the checksum offset a simple 'offset << CONSTANT'
is enough.
If it is the bottom bits then even that isn't really needed.
You might want to mask off high bits - but that is an error
path that needs to have been checked earlier.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)