netdev - RE: [PATCH v10 04/20] dlb: add device ioctl layer and first three ioctls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR11MB3095E9D74CCBC85704EA3AECD9919@BYAPR11MB3095.namprd11.prod.outlook.com>
Date:   Wed, 10 Mar 2021 01:34:30 +0000
From:   "Chen, Mike Ximing" <mike.ximing.chen@...el.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Subject: RE: [PATCH v10 04/20] dlb: add device ioctl layer and first three
 ioctls

> From: Greg KH <gregkh@...uxfoundation.org>
> On Wed, Feb 10, 2021 at 11:54:07AM -0600, Mike Ximing Chen wrote:
> > +/*
> > + * DLB_CMD_CREATE_SCHED_DOMAIN: Create a DLB 2.0 scheduling domain and
> reserve
> > + *	its hardware resources. This command returns the newly created domain
> > + *	ID and a file descriptor for accessing the domain.
> > + *
> > + * Output parameters:
> > + * @response.status: Detailed error code. In certain cases, such as if the
> > + *	ioctl request arg is invalid, the driver won't set status.
> > + * @response.id: domain ID.
> > + * @domain_fd: file descriptor for performing the domain's ioctl operations
> > + * @padding0: Reserved for future use.
> 
> For all of your paddingX fields, you MUST check that they are set to 0
> by userspace now, otherwise they will never be able to actually be used
> in the future.
> 
> But why do you need them at all anyway?  If something needs to be
> changed in the future, just add a new ioctl, don't modify something that
> is already working.  Are you _SURE_ you need this type of functionality?
> 
OK, we don't need the padding fields then, and will remove them.

Thanks
Mike