[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CO6PR18MB3873813B7C30F2BE0095C061B0919@CO6PR18MB3873.namprd18.prod.outlook.com>
Date: Wed, 10 Mar 2021 16:37:58 +0000
From: Stefan Chulski <stefanc@...vell.com>
To: Andrew Lunn <andrew@...n.ch>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"thomas.petazzoni@...tlin.com" <thomas.petazzoni@...tlin.com>,
"davem@...emloft.net" <davem@...emloft.net>,
Nadav Haklai <nadavh@...vell.com>,
Yan Markman <ymarkman@...vell.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"kuba@...nel.org" <kuba@...nel.org>,
"linux@...linux.org.uk" <linux@...linux.org.uk>,
"mw@...ihalf.com" <mw@...ihalf.com>,
"rmk+kernel@...linux.org.uk" <rmk+kernel@...linux.org.uk>,
"atenart@...nel.org" <atenart@...nel.org>,
"rabeeh@...id-run.com" <rabeeh@...id-run.com>
Subject: RE: [EXT] Re: [net-next] net: mvpp2: Add reserved port private flag
configuration
> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Wednesday, March 10, 2021 5:51 PM
> To: Stefan Chulski <stefanc@...vell.com>
> Cc: netdev@...r.kernel.org; thomas.petazzoni@...tlin.com;
> davem@...emloft.net; Nadav Haklai <nadavh@...vell.com>; Yan
> Markman <ymarkman@...vell.com>; linux-kernel@...r.kernel.org;
> kuba@...nel.org; linux@...linux.org.uk; mw@...ihalf.com;
> rmk+kernel@...linux.org.uk; atenart@...nel.org; rabeeh@...id-run.com
> Subject: [EXT] Re: [net-next] net: mvpp2: Add reserved port private flag
> configuration
>
> External Email
>
> ----------------------------------------------------------------------
> > static void mvpp2_ethtool_get_strings(struct net_device *netdev, u32
> sset,
> > u8 *data)
> > {
> > struct mvpp2_port *port = netdev_priv(netdev);
> > int i, q;
> >
> > - if (sset != ETH_SS_STATS)
> > - return;
> > + switch (sset) {
> > + case ETH_SS_STATS:
> > + for (i = 0; i < ARRAY_SIZE(mvpp2_ethtool_mib_regs); i++) {
> > + strscpy(data, mvpp2_ethtool_mib_regs[i].string,
> > + ETH_GSTRING_LEN);
> > + data += ETH_GSTRING_LEN;
> > + }
>
> Hi Stefan
>
> Maybe rename the existing function to
> mvpp2_ethtool_get_strings_stats() and turn it into a helper. Add a new
> mvpp2_ethtool_get_strings_priv() helper. And a new
> mvpp2_ethtool_get_strings() which just calls the two helpers.
OK, I can do this.
> Overall the
> patch should be smaller and much easier to review.
>
> Andrew
Make it patch series? I can split it to 2/3 patches.
Thanks,
Stefan.
Powered by blists - more mailing lists