netdev - Re: [PATCH net-next] net: ipv6: addrconf: Add accept_ra_prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7bb2c1d-1e9a-5191-96bd-c3d567df2da1@gmail.com>
Date:   Wed, 10 Mar 2021 12:28:49 -0700
From:   David Ahern <dsahern@...il.com>
To:     Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>,
        davem@...emloft.net, kuba@...nel.org, yoshfuji@...ux-ipv6.org,
        dsahern@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: ipv6: addrconf: Add accept_ra_prefix_route.

On 3/10/21 11:49 AM, Subash Abhinov Kasiviswanathan wrote:
> Added new procfs flag to toggle the automatic addition of prefix
> routes on a per device basis. The new flag is accept_ra_prefix_route.
> 
> A value of 0 for the flag maybe used in some forwarding scenarios
> when a userspace daemon is managing the routing.
> Manual deletion of the kernel installed route was not sufficient as
> kernel was adding back the route.
> 
> Defaults to 1 as to not break existing behavior.
> 
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
> ---
>  Documentation/networking/ip-sysctl.rst | 10 ++++++++++
>  include/linux/ipv6.h                   |  1 +
>  include/uapi/linux/ipv6.h              |  1 +
>  net/ipv6/addrconf.c                    | 16 +++++++++++++---
>  4 files changed, 25 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
> index c7952ac..9f0d92d 100644
> --- a/Documentation/networking/ip-sysctl.rst
> +++ b/Documentation/networking/ip-sysctl.rst
> @@ -2022,6 +2022,16 @@ accept_ra_mtu - BOOLEAN
>  		- enabled if accept_ra is enabled.
>  		- disabled if accept_ra is disabled.
>  
> +accept_ra_prefix_route - BOOLEAN
> +	Apply the prefix route based on the RA. If disabled, kernel
> +	does not install the route. This can be used if a userspace
> +	daemon is managing the routing.
> +
> +	Functional default:
> +
> +		- enabled if accept_ra_prefix_route is enabled
> +		- disabled if accept_ra_prefix_route is disabled
> +
>  accept_redirects - BOOLEAN
>  	Accept Redirects.
>  

this seems to duplicate accept_ra_pinfo