netdev - Re: [PATCH bpf-next 2/2] libbpf: xsk: move barriers from libbpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzYPDF87At4=_gsndxof84OiqyJxgAHL7_jvpuntovUQ8w@mail.gmail.com>
Date:   Wed, 10 Mar 2021 14:00:48 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Björn Töpel <bjorn.topel@...il.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Björn Töpel <bjorn.topel@...el.com>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>, maximmi@...dia.com,
        ciara.loftus@...el.com
Subject: Re: [PATCH bpf-next 2/2] libbpf: xsk: move barriers from
 libbpf_util.h to xsk.h

On Wed, Mar 10, 2021 at 12:09 AM Björn Töpel <bjorn.topel@...il.com> wrote:
>
> From: Björn Töpel <bjorn.topel@...el.com>
>
> The only user of libbpf_util.h is xsk.h. Move the barriers to xsk.h,
> and remove libbpf_util.h. The barriers are used as an implementation
> detail, and should not be considered part of the stable API.
>
> Signed-off-by: Björn Töpel <bjorn.topel@...el.com>
> ---
>  tools/lib/bpf/Makefile      |  1 -
>  tools/lib/bpf/libbpf_util.h | 82 -------------------------------------
>  tools/lib/bpf/xsk.h         | 68 +++++++++++++++++++++++++++++-
>  3 files changed, 67 insertions(+), 84 deletions(-)
>  delete mode 100644 tools/lib/bpf/libbpf_util.h
>

[...]

> diff --git a/tools/lib/bpf/xsk.h b/tools/lib/bpf/xsk.h
> index a9fdea87b5cd..1d846a419d21 100644
> --- a/tools/lib/bpf/xsk.h
> +++ b/tools/lib/bpf/xsk.h
> @@ -4,6 +4,7 @@
>   * AF_XDP user-space access library.
>   *
>   * Copyright(c) 2018 - 2019 Intel Corporation.

Couldn't unsee ^this mismatch. Added space there.

Also, removing libbpf_util.h caused incremental build failure for the
kernel due to cached dependency files. make clean solved the issue. So
just FYI for everyone.

Applied to bpf-next, thanks.

> + * Copyright (c) 2019 Facebook
>   *
>   * Author(s): Magnus Karlsson <magnus.karlsson@...el.com>
>   */
> @@ -13,15 +14,80 @@
>
>  #include <stdio.h>
>  #include <stdint.h>
> +#include <stdbool.h>
>  #include <linux/if_xdp.h>
>
>  #include "libbpf.h"
> -#include "libbpf_util.h"
>
>  #ifdef __cplusplus
>  extern "C" {
>  #endif
>

[...]