lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20210310.154538.199786368593752214.davem@davemloft.net>
Date:   Wed, 10 Mar 2021 15:45:38 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     zajec5@...il.com
Cc:     kuba@...nel.org, robh+dt@...nel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, f.fainelli@...il.com,
        bcm-kernel-feedback-list@...adcom.com, rafal@...ecki.pl
Subject: Re: [PATCH net-next 2/2] net: broadcom: bcm4908_enet: support TX
 interrupt

From: Rafaİİ Miİİecki <zajec5@...il.com>
Date: Wed, 10 Mar 2021 10:14:10 +0100

>  
> +	if (enet->irq_tx >= 0) {
...
> +	if (enet->irq_tx > 0) {

Tests are not consistent, please fix.

Thank you.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ